CLASSROOMIO-T-82: Attendance Page Redesign

CLASSROOMIO-T-82: Fix sidebar navs

CLASSROOMIO-T-82: Dark Mode Icon Fix

CLASSROOMIO-T-82: Icon Dark Mode Final fix

CLASSROOMIO-T-82: Dark mode icon fix

CLASSROOMIO-T-82: Icon Dark Mode fix

Merge branch 'CLASSROOMIO-T-82' of https://gitlab.com/thenextgreat/classroomio into CLASSROOMIO-T-82

CLASSROOMIO-T-82:
- Impliment Search Functionality
- Dark Mode Fix

Merge branch 'main' into CLASSROOMIO-T-82

CLASSROOMIO-T-82: Saving fix and dark mode button bug

Merge branch 'main' into CLASSROOMIO-T-82

CLASSROOMIO-T-82: Attendance Redesign

CLASSROOMIO-T-82: Redesign Attendance Page


Co-authored-by: Rotimi Best <rotimiibitoyeemma@gmail.com>
Co-authored-by: tunny17 <tvnji17@gmail.com>


Merge-request: CLASSROOMIO-MR-34
Merged-by: Best Admin <best@digdippa.com>
This commit is contained in:
tunny17
2023-08-07 09:53:07 +00:00
committed by Space Cloud
co-authored by Rotimi Best
parent a9c8fbb1fd
commit 8465ba5371
8 changed files with 123 additions and 92 deletions
@@ -12,7 +12,7 @@
export let total = 0; export let total = 0;
// export let subMenuItems = []; // export let subMenuItems = [];
let activeClass = 'bg-gray-200 dark:bg-gray-500'; let activeClass = 'bg-gray-200 dark:bg-gray-800';
function onClick() { function onClick() {
handleClick(); handleClick();
@@ -25,7 +25,7 @@
<div class=""> <div class="">
<button <button
class="item relative flex items-center py-3 px-4 ml-2 mb-1 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isGroupActive && class="item relative flex items-center py-3 px-4 ml-2 mb-1 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isGroupActive &&
activeClass} w-[95%]" activeClass} w-[95%]"
tabindex="0" tabindex="0"
on:click={onClick} on:click={onClick}
@@ -32,7 +32,7 @@
export let isStudent = null; export let isStudent = null;
let show = null; let show = null;
let activeClass = 'bg-gray-200 dark:bg-gray-500'; let activeClass = 'bg-gray-200 dark:bg-gray-800';
let isLessonActive = false; let isLessonActive = false;
function handleMainGroupClick(href) { function handleMainGroupClick(href) {
@@ -200,7 +200,7 @@
aria-disabled={!item.is_unlocked} aria-disabled={!item.is_unlocked}
> >
<div <div
class="flex items-center py-3 px-4 rounded hover:bg-gray-200 dark:hover:bg-gray-500 w-full {( class="flex items-center py-3 px-4 rounded hover:bg-gray-200 dark:hover:bg-gray-800 w-full {(
path || $page.url.pathname path || $page.url.pathname
).includes(item.id) && activeClass}" ).includes(item.id) && activeClass}"
> >
+6 -6
View File
@@ -11,7 +11,7 @@
import { currentOrg } from '$lib/utils/store/org'; import { currentOrg } from '$lib/utils/store/org';
import { profile } from '$lib/utils/store/user'; import { profile } from '$lib/utils/store/user';
let activeClass = 'bg-gray-200 dark:bg-gray-500'; let activeClass = 'bg-gray-200 dark:bg-gray-800';
function isActive(pagePath, itemPath) { function isActive(pagePath, itemPath) {
const pageLinkItems = pagePath.split('/'); const pageLinkItems = pagePath.split('/');
@@ -45,7 +45,7 @@
<ul class="my-5"> <ul class="my-5">
<a href="/lms" class="text-black"> <a href="/lms" class="text-black">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isActive( class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isActive(
$page.url.pathname, $page.url.pathname,
`/lms` `/lms`
) && activeClass}" ) && activeClass}"
@@ -56,7 +56,7 @@
</a> </a>
<a href="/lms/mylearning" class="text-black"> <a href="/lms/mylearning" class="text-black">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isActive( class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isActive(
$page.url.pathname, $page.url.pathname,
`/lms/mylearning` `/lms/mylearning`
) && activeClass}" ) && activeClass}"
@@ -67,7 +67,7 @@
</a> </a>
<a href="/lms/exercises" class="text-black"> <a href="/lms/exercises" class="text-black">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isActive( class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isActive(
$page.url.pathname, $page.url.pathname,
`/lms/exercises` `/lms/exercises`
) && activeClass}" ) && activeClass}"
@@ -82,7 +82,7 @@
<ul class="my-5 pb-5 px-4"> <ul class="my-5 pb-5 px-4">
<a href="/lms" class="text-black"> <a href="/lms" class="text-black">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500" class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800"
> >
<HelpIcon size={20} class="carbon-icon dark:text-white" /> <HelpIcon size={20} class="carbon-icon dark:text-white" />
<p class="dark:text-white ml-2">Help</p> <p class="dark:text-white ml-2">Help</p>
@@ -90,7 +90,7 @@
</a> </a>
<a href="/lms/settings" class="text-black"> <a href="/lms/settings" class="text-black">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isActive( class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isActive(
$page.url.pathname, $page.url.pathname,
`/lms/settings` `/lms/settings`
) && activeClass}" ) && activeClass}"
+2 -2
View File
@@ -14,7 +14,7 @@
import { currentOrg, currentOrgPath } from '$lib/utils/store/org'; import { currentOrg, currentOrgPath } from '$lib/utils/store/org';
import { profile } from '$lib/utils/store/user'; import { profile } from '$lib/utils/store/user';
let activeClass = 'bg-gray-200 dark:bg-gray-700'; let activeClass = 'bg-gray-200 dark:bg-gray-800';
const menuItems = [ const menuItems = [
{ {
@@ -76,7 +76,7 @@
{#each menuItems as menuItem} {#each menuItems as menuItem}
<a href="{$currentOrgPath}{menuItem.path}" class="text-black no-underline"> <a href="{$currentOrgPath}{menuItem.path}" class="text-black no-underline">
<li <li
class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-500 {isActive( class="flex items-center py-3 px-4 mb-2 rounded hover:bg-gray-200 dark:hover:bg-gray-800 {isActive(
$page.url.pathname, $page.url.pathname,
`${$currentOrgPath}${menuItem.path}` `${$currentOrgPath}${menuItem.path}`
) && activeClass}" ) && activeClass}"
@@ -18,7 +18,7 @@ export const VARIANTS_CLASS = {
[VARIANTS.CONTAINED_SUCCESS]: 'bg-green-700 hover:bg-green-900 text-white', [VARIANTS.CONTAINED_SUCCESS]: 'bg-green-700 hover:bg-green-900 text-white',
[VARIANTS.CONTAINED_DANGER]: 'bg-red-700 hover:bg-red-900 text-white', [VARIANTS.CONTAINED_DANGER]: 'bg-red-700 hover:bg-red-900 text-white',
[VARIANTS.OUTLINED]: [VARIANTS.OUTLINED]:
'border border-blue-700 hover:border-black-300 hover:bg-blue-700 text-black hover:text-white', 'border border-blue-700 hover:border-black-300 hover:bg-blue-700 text-black hover:text-white dark:text-white',
[VARIANTS.NONE]: [VARIANTS.NONE]:
'border-none hover:border-black-300 hover:bg-gray-200 dark:hover:bg-gray-500 text-black', 'border-none hover:border-black-300 hover:bg-gray-200 dark:hover:bg-gray-500 text-black',
[VARIANTS.TEXT]: 'text-black hover:underline', [VARIANTS.TEXT]: 'text-black hover:underline',
+1 -1
View File
@@ -1,5 +1,5 @@
import { supabase } from '$lib/utils/functions/supabase'; import { supabase } from '$lib/utils/functions/supabase';
export async function takeAttendance(update) { export async function takeAttendance(update) {
return supabase.from('group_attendance').upsert(update); return supabase.from('group_attendance').upsert(update).select();
} }
+8
View File
@@ -376,4 +376,12 @@
:global(.border-bottom-c) { :global(.border-bottom-c) {
border-bottom: 1px solid var(--border-color); border-bottom: 1px solid var(--border-color);
} }
:global(.bx--search-close > svg) {
fill: black;
}
:global(.dark .bx--search-close:hover > svg) {
fill: #fff;
}
</style> </style>
+101 -78
View File
@@ -1,5 +1,15 @@
<script> <script>
import { onMount } from 'svelte'; import { onMount } from 'svelte';
import {
Search,
Checkbox,
StructuredList,
StructuredListBody,
StructuredListCell,
StructuredListHead,
StructuredListRow,
Pagination
} from 'carbon-components-svelte';
import AudioConsoleIcon from 'carbon-icons-svelte/lib/AudioConsole.svelte'; import AudioConsoleIcon from 'carbon-icons-svelte/lib/AudioConsole.svelte';
import CourseContainer from '$lib/components/CourseContainer/index.svelte'; import CourseContainer from '$lib/components/CourseContainer/index.svelte';
import PageNav from '$lib/components/PageNav/index.svelte'; import PageNav from '$lib/components/PageNav/index.svelte';
@@ -21,6 +31,7 @@
let borderBottomGrey = 'border-r-0 border-b border-l-0 border-gray-300'; let borderBottomGrey = 'border-r-0 border-b border-l-0 border-gray-300';
let students = []; let students = [];
let isStudent; let isStudent;
let searchValue = '';
function setAttendance(courseData) { function setAttendance(courseData) {
for (const attendanceItem of courseData.attendance) { for (const attendanceItem of courseData.attendance) {
@@ -30,16 +41,16 @@
$attendance[student_id] = { $attendance[student_id] = {
[lesson_id]: { [lesson_id]: {
id, id,
is_present, is_present
}, }
}; };
} else { } else {
$attendance[student_id] = { $attendance[student_id] = {
...$attendance[student_id], ...$attendance[student_id],
[lesson_id]: { [lesson_id]: {
id, id,
is_present, is_present
}, }
}; };
} }
} }
@@ -48,9 +59,7 @@
function handleAttendanceChange(e, student, lesson) { function handleAttendanceChange(e, student, lesson) {
if (isStudent) return; if (isStudent) return;
const attendanceItem = $attendance[student.id] const attendanceItem = $attendance[student.id] ? $attendance[student.id][lesson.id] || {} : {};
? $attendance[student.id][lesson.id] || {}
: {};
/* /*
This validation is useless. We shouldn't assume we already have an attendance item id This validation is useless. We shouldn't assume we already have an attendance item id
@@ -71,7 +80,7 @@
student_id: student.id, student_id: student.id,
is_present: e.target.checked, is_present: e.target.checked,
lesson_id: lesson.id, lesson_id: lesson.id,
course_id: data.courseId, course_id: data.courseId
}; };
takeAttendance(_data).then((res) => { takeAttendance(_data).then((res) => {
@@ -79,28 +88,35 @@
console.error(`res.error`, res.error); console.error(`res.error`, res.error);
$snackbarStore.open = true; $snackbarStore.open = true;
$snackbarStore.severity = SNACKBAR_SEVERITY.ERROR; $snackbarStore.severity = SNACKBAR_SEVERITY.ERROR;
$snackbarStore.message = $snackbarStore.message = "Something isn't right. Please reload and take attendance again";
"Something isn't right. Please reload and take attendance again";
} else { } else {
// console.log('res', JSON.stringify(res)); // console.log('res', JSON.stringify(res));
const { id, is_present } = res.data[0]; const { id, is_present } = res.data[0];
if ($attendance[student.id]) { if ($attendance[student.id]) {
$attendance[student.id][lesson.id] = { $attendance[student.id][lesson.id] = {
id, id,
is_present, is_present
}; };
} else { } else {
$attendance[student.id] = { $attendance[student.id] = {
[lesson.id]: { [lesson.id]: {
id, id,
is_present, is_present
}, }
}; };
} }
} }
}); });
} }
// function for the searchbar
function searchStudents(query) {
const lowercaseQuery = query.toLowerCase();
return students.filter((student) =>
student.profile.fullname.toLowerCase().includes(lowercaseQuery)
);
}
onMount(async () => { onMount(async () => {
if ($course.id) { if ($course.id) {
if (!Object.keys($attendance).length) { if (!Object.keys($attendance).length) {
@@ -115,78 +131,85 @@
}); });
$: students = isStudent $: students = isStudent
? $group.people.filter( ? $group.people.filter((person) => !!person.profile && person.profile.id === $profile.id)
(person) => !!person.profile && person.profile.id === $profile.id : $group.people.filter((person) => !!person.profile && person.role_id === ROLE.STUDENT);
) console.log(students);
: $group.people.filter(
(person) => !!person.profile && person.role_id === ROLE.STUDENT
);
</script> </script>
<CourseContainer bind:isStudent> <CourseContainer bind:isStudent>
<PageNav title="Attendance" /> <PageNav title="Attendance" />
<PageBody>
<div class="table rounded-md border border-gray-300 w-full">
<div
class="flex items-center font-bold border-t-0 {borderBottomGrey} p-3"
>
<p class="dark:text-white w-1/4">Student</p>
{#each $lessons as lesson, index}
<p class="dark:text-white col" title={lesson.title}>
{getLectureNo(index + 1)}
</p>
{/each}
</div>
{#each students as student} <section class="mx-9 my-5">
<div <div class="flex flex-row items-center justify-between">
class="flex relative items-center p-3 cursor-pointer {borderBottomGrey}" <div class="flex">
> <p class="flex items-center mr-5">
<div class="w-1/4 flex items-center"> <Checkbox checked disabled /> Present
<img </p>
alt="Student avatar" <p class="flex items-center">
src={student.profile.avatar_url} <Checkbox disabled /> Absent
class="w-8 h-8 rounded-full mr-2" </p>
/> </div>
<div class="text-sm"> <div class="dark:">
<p class="dark:text-white font-semibold"> <Search
{student.profile.fullname} class="dark:text-slate-950"
</p> placeholder="Search students"
{#if student.assigned_student_id} bind:value={searchValue}
<p class="dark:text-white">#{student.assigned_student_id}</p> />
{/if} </div>
</div> </div>
</div> </section>
{#each $lessons as lesson}
<p class="dark:text-white col"> <section class="my-5 mx-9">
<input <StructuredList class="m-0">
class="form-radio {isStudent && 'cursor-not-allowed'}" <!-- Moved the lesson headers outside the students loop -->
type="checkbox" <StructuredListHead class="bg-blue-100">
disabled={isStudent} <StructuredListRow head class="mx-7">
checked={$attendance[student.id] <StructuredListCell head class="text-blue-600 py-3">Student</StructuredListCell>
? $attendance[student.id][lesson.id] {#each $lessons as lesson, index}
? $attendance[student.id][lesson.id].is_present <StructuredListCell head class="text-blue-600 py-3"
: false >Lesson 0{getLectureNo(index + 1)}</StructuredListCell
: false} >
on:change={(e) => handleAttendanceChange(e, student, lesson)}
/>
</p>
{/each} {/each}
</div> </StructuredListRow>
{:else} </StructuredListHead>
{#each searchStudents(searchValue) as student}
<StructuredListBody>
<StructuredListRow>
<StructuredListCell>
<div class="w-1/4 flex items-center">
<p class="dark:text-white font-semibold">
{student.profile.fullname}
</p>
</div>
</StructuredListCell>
{#each $lessons as lesson}
<StructuredListCell class="">
<Checkbox
class={isStudent && 'cursor-not-allowed'}
disabled={isStudent}
checked={$attendance[student.id]
? $attendance[student.id][lesson.id]
? $attendance[student.id][lesson.id].is_present
: false
: false}
on:change={(e) => handleAttendanceChange(e, student, lesson)}
/>
</StructuredListCell>
{/each}
</StructuredListRow>
</StructuredListBody>
{/each}
</StructuredList>
{#if students.length === 0}
<div>
<Box> <Box>
<AudioConsoleIcon size={32} class="carbon-icon w-80" /> <AudioConsoleIcon size={32} class="carbon-icon w-80" />
<h3 class="text-3xl text-gray-500 dark:text-white"> <h3 class="text-3xl text-gray-500 dark:text-white">No Student Added</h3>
No Student Added
</h3>
</Box> </Box>
{/each} </div>
</div> {/if}
</PageBody>
</CourseContainer>
<style> <Pagination totalItems={10} pageSizes={[10, 15, 20]} />
.col { </section>
width: 50px; </CourseContainer>
}
</style>