ulivargas/classroomio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow taking attendance if not taken before

Browse Source
This commit is contained in:
Rotimi Best
2021-11-13 21:29:26 +02:00
parent aef491da32
commit a1f6c5728b
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
package-lock.json
Generated
+3 -3
View File
@@ -1330,9 +1330,9 @@
} }
}, },
"@rollup/plugin-typescript": { "@rollup/plugin-typescript": {
"version": "8.2.5", "version": "8.3.0",
"resolved": "https://registry.npmjs.org/@rollup/plugin-typescript/-/plugin-typescript-8.2.5.tgz", "resolved": "https://flipplib.jfrog.io/artifactory/api/npm/flipp-npm/@rollup/plugin-typescript/-/plugin-typescript-8.3.0.tgz",
"integrity": "sha512-QL/LvDol/PAGB2O0S7/+q2HpSUNodpw7z6nGn9BfoVCPOZ0r4EALrojFU29Bkoi2Hr2jgTocTejJ5GGWZfOxbQ==", "integrity": "sha1-vBB3+liXuYD8J+N2xON3iCxj5os=",
"dev": true, "dev": true,
"requires": { "requires": {
"@rollup/pluginutils": "^3.1.0", "@rollup/pluginutils": "^3.1.0",
package.json
+1 -1
View File
@@ -44,7 +44,7 @@
"@rollup/plugin-commonjs": "^14.0.0", "@rollup/plugin-commonjs": "^14.0.0",
"@rollup/plugin-node-resolve": "^8.0.0", "@rollup/plugin-node-resolve": "^8.0.0",
"@rollup/plugin-replace": "^2.4.2", "@rollup/plugin-replace": "^2.4.2",
"@rollup/plugin-typescript": "^8.2.5", "@rollup/plugin-typescript": "^8.3.0",
"@tailwindcss/typography": "^0.3.1", "@tailwindcss/typography": "^0.3.1",
"carbon-icons-svelte": "^10.21.0", "carbon-icons-svelte": "^10.21.0",
"dotenv": "^10.0.0", "dotenv": "^10.0.0",
src/routes/courses/[id]/attendance.svelte
+7 -2
View File
@@ -62,6 +62,9 @@
? $attendance[student.id][lesson.id] || {} ? $attendance[student.id][lesson.id] || {}
: {}; : {};
/*
This validation is useless. We shouldn't assume we already have an attendance item id
because it might be a new attendance.
if (!attendanceItem.id) { if (!attendanceItem.id) {
$snackbarStore.open = true; $snackbarStore.open = true;
$snackbarStore.severity = SNACKBAR_SEVERITY.ERROR; $snackbarStore.severity = SNACKBAR_SEVERITY.ERROR;
@@ -71,6 +74,7 @@
return; return;
} }
*/
const data = { const data = {
id: attendanceItem.id, id: attendanceItem.id,
@@ -85,9 +89,10 @@
console.error(`res.error`, res.error); console.error(`res.error`, res.error);
$snackbarStore.open = true; $snackbarStore.open = true;
$snackbarStore.severity = SNACKBAR_SEVERITY.ERROR; $snackbarStore.severity = SNACKBAR_SEVERITY.ERROR;
$snackbarStore.message = "Something isn't right."; $snackbarStore.message =
"Something isn't right. Please reload and take attendance again";
} else { } else {
console.log('res', JSON.stringify(res)); // console.log('res', JSON.stringify(res));
const { id, is_present } = res.data[0]; const { id, is_present } = res.data[0];
if ($attendance[student.id]) { if ($attendance[student.id]) {
$attendance[student.id][lesson.id] = { $attendance[student.id][lesson.id] = {