ulivargas/classroomio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dashboard): show course cards in landing page settings preview (#697)

Browse Source 
* fix(dashboard): show course cards in landing page settings preview

Fetch public courses for the org and pass them to the theme preview
on the landing page settings screen, matching the editor preview.

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

* refactor(dashboard): skip redundant public course fetches

Add loadPublicCoursesIfNeeded so settings, editor, and live landing
page reuse cached courses for the same org site instead of clearing
and refetching on every mount.

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

* fix(dashboard): always refetch courses on live org landing page

Keep loadPublicCoursesIfNeeded for settings preview and editor only.
The public-facing landing page should fetch fresh on each visit.

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

* feat(ui): add shared empty state for org landing page catalogs

Introduce OrgLandingPageCoursesEmpty using the dashboard Empty pattern
with landing-theme colors. Show it across all ten org landing templates
when no courses are published, and wire translated labels through
buildOrgLandingPageProps.

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

* fix(dashboard): address Greptile review on public courses cache

- Add coursesLoaded prop so empty catalog state waits for fetch
- Deduplicate concurrent public course requests via in-flight promise
- Refresh courses on settings mount; reuse cache in editor only
- Expose invalidatePublicCourses for explicit cache clearing

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

* fix(dashboard): load landing preview courses when org store hydrates

Replace onMount course fetch with a reactive effect keyed on the route
slug and currentOrg.siteName so public courses load after app init.
Mark the fetch as complete in finally so failed requests show the empty
state instead of a permanently blank catalog section.

Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>

---------
This commit is contained in:
Rotimi Best
2026-07-06 20:51:17 +01:00
committed by GitHub
co-authored by Rotimi Best
parent 8a22ee60bc
commit bce38aa530
28 changed files with 571 additions and 359 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/dashboard/src/routes/(app)/org/[slug]/settings/landingpage/edit/+page.svelte
+12 -9
View File
@@ -1,6 +1,6 @@
<script lang="ts">
import { fly } from 'svelte/transition';
import { onMount, type Component } from 'svelte';
import type { Component } from 'svelte';
import { resolve } from '$app/paths';
import { page } from '$app/state';
import { goto } from '$app/navigation';
@@ -90,24 +90,27 @@
}
);
const previewProps = $derived(
const previewSiteName = $derived($currentOrg.siteName || page.params.slug || '');
const coursesLoaded = $derived(!previewSiteName || orgApi.publicCoursesLoadedSiteName === previewSiteName);
const previewProps = $derived.by(() =>
buildOrgLandingPageProps(
$currentOrg,
previewLandingPageSettings,
orgApi.publicCourses,
orgApi.hasMorePublicCourses,
authAction
authAction,
{ coursesLoaded }
)
);
const ThemeComponent = $derived(landingPageThemeComponents[previewTheme] ?? landingPageThemeComponents.minimal);
onMount(() => {
if ($currentOrg.siteName) {
orgApi.publicCourses = [];
orgApi.hasMorePublicCourses = false;
void orgApi.getPublicCoursesBySiteName($currentOrg.siteName);
}
$effect(() => {
if (!previewSiteName) return;
void orgApi.loadPublicCoursesIfNeeded(previewSiteName);
});
$effect(() => {