From f0695e9d1866eb835bd7f13da9bdebe9d2fe66cd Mon Sep 17 00:00:00 2001 From: Richard Kenneth <79406473+richarddkenneth@users.noreply.github.com> Date: Wed, 12 Aug 2026 07:09:54 +0100 Subject: [PATCH] fix(dashboard): Certain menus inside of modals are hidden (#875) * fix: update z-index utility class for Select component across tag category and tutor selection views * refactor: standardize z-index management using ui:z-menu-elevated, ui:z-app-bar, ui:z-app-bar-elevated and ui:z-modal classes across UI components --------- Co-authored-by: richardkenneth --- .vscode/settings.json | 1 + apps/dashboard/src/app.css | 26 ------------------- .../features/ai-assistant/chat-header.svelte | 2 +- .../cohort/components/cohort-header.svelte | 2 +- .../components/sidebar/cohort-sidebar.svelte | 2 +- .../course/components/course-header.svelte | 2 +- .../exercise/mark-exercise-modal.svelte | 4 +-- .../lesson/document/document.svelte | 2 +- .../components/sidebar/course-sidebar.svelte | 2 +- .../lib/features/course/pages/exercise.svelte | 6 ++--- .../side-panel/side-panel-rail.svelte | 2 +- .../lib/features/tag/pages/tags-admin.svelte | 4 +-- .../components/editor/pricing-form.svelte | 2 +- .../dropdown-menu-content.svelte | 2 +- .../dropdown-menu-sub-content.svelte | 2 +- .../src/base/popover/popover-content.svelte | 2 +- .../ui/src/base/select/select-content.svelte | 2 +- 17 files changed, 20 insertions(+), 45 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 750b2255..7dae54ee 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -18,6 +18,7 @@ ], "deno.importMap": "./supabase/functions/import_map.json", "editor.formatOnSave": true, + "editor.wordWrap": "on", "[svelte]": { "editor.defaultFormatter": "svelte.svelte-vscode" }, diff --git a/apps/dashboard/src/app.css b/apps/dashboard/src/app.css index a1b3aaca..2fd6b20f 100644 --- a/apps/dashboard/src/app.css +++ b/apps/dashboard/src/app.css @@ -8,32 +8,6 @@ @custom-variant dark (&:where(.dark, .dark *)); -/** - * Shared z-index scale, mirrored from `packages/ui/src/index.css`. - * - * Dashboard code has its own (unprefixed) Tailwind pipeline, separate from `@cio/ui`'s - * `ui:`-prefixed one — a `ui:`-prefixed utility only compiles if that exact class string is - * also used somewhere under `packages/ui/src`. So dashboard-only usages (page headers, the - * course sidebar, dropdowns/selects that need to escape a sticky header or a modal) must use - * these unprefixed names instead. Keep the two scales numerically in sync; see - * `packages/ui/README.md` for the full write-up of each layer. - */ -@utility z-app-bar { - z-index: 100; -} - -@utility z-app-bar-elevated { - z-index: 150; -} - -@utility z-modal { - z-index: 200; -} - -@utility z-menu-elevated { - z-index: 250; -} - /* Geist variable font — self-hosted */ @font-face { font-family: 'Geist'; diff --git a/apps/dashboard/src/lib/features/ai-assistant/chat-header.svelte b/apps/dashboard/src/lib/features/ai-assistant/chat-header.svelte index 53c7d60b..6c64f077 100644 --- a/apps/dashboard/src/lib/features/ai-assistant/chat-header.svelte +++ b/apps/dashboard/src/lib/features/ai-assistant/chat-header.svelte @@ -229,7 +229,7 @@ {/snippet} - +
diff --git a/apps/dashboard/src/lib/features/cohort/components/sidebar/cohort-sidebar.svelte b/apps/dashboard/src/lib/features/cohort/components/sidebar/cohort-sidebar.svelte index 019a9267..723e22c3 100644 --- a/apps/dashboard/src/lib/features/cohort/components/sidebar/cohort-sidebar.svelte +++ b/apps/dashboard/src/lib/features/cohort/components/sidebar/cohort-sidebar.svelte @@ -29,7 +29,7 @@ {#if !isOrgLoaded} {:else} - + diff --git a/apps/dashboard/src/lib/features/course/components/course-header.svelte b/apps/dashboard/src/lib/features/course/components/course-header.svelte index e51c1c1e..6135d87f 100644 --- a/apps/dashboard/src/lib/features/course/components/course-header.svelte +++ b/apps/dashboard/src/lib/features/course/components/course-header.svelte @@ -59,7 +59,7 @@
diff --git a/apps/dashboard/src/lib/features/course/components/exercise/mark-exercise-modal.svelte b/apps/dashboard/src/lib/features/course/components/exercise/mark-exercise-modal.svelte index 6dad6499..2bdcdff7 100644 --- a/apps/dashboard/src/lib/features/course/components/exercise/mark-exercise-modal.svelte +++ b/apps/dashboard/src/lib/features/course/components/exercise/mark-exercise-modal.svelte @@ -296,7 +296,7 @@ > - + { @@ -366,7 +366,7 @@ {status.text} - + {#each SELECTABLE_STATUS as statusOption} {statusOption.text} diff --git a/apps/dashboard/src/lib/features/course/components/lesson/document/document.svelte b/apps/dashboard/src/lib/features/course/components/lesson/document/document.svelte index 90bec091..93ccfc7f 100644 --- a/apps/dashboard/src/lib/features/course/components/lesson/document/document.svelte +++ b/apps/dashboard/src/lib/features/course/components/lesson/document/document.svelte @@ -339,7 +339,7 @@ {#if pdfViewerOpen} -
+
diff --git a/apps/dashboard/src/lib/features/course/components/sidebar/course-sidebar.svelte b/apps/dashboard/src/lib/features/course/components/sidebar/course-sidebar.svelte index c9663300..4dd2079f 100644 --- a/apps/dashboard/src/lib/features/course/components/sidebar/course-sidebar.svelte +++ b/apps/dashboard/src/lib/features/course/components/sidebar/course-sidebar.svelte @@ -118,7 +118,7 @@ {#if !isOrgLoaded} {:else} - + diff --git a/apps/dashboard/src/lib/features/course/pages/exercise.svelte b/apps/dashboard/src/lib/features/course/pages/exercise.svelte index 339c06d9..1d689ca2 100644 --- a/apps/dashboard/src/lib/features/course/pages/exercise.svelte +++ b/apps/dashboard/src/lib/features/course/pages/exercise.svelte @@ -592,7 +592,7 @@ } - + {exerciseDisplayTitle} @@ -638,7 +638,7 @@ {/snippet} - + {$t('course.navItem.lessons.exercises.all_exercises.add_section')} @@ -677,7 +677,7 @@ {/snippet} - + {#if hasSections($questionnaire.sections)} (reorderQuestions = !reorderQuestions)}> {reorderQuestions diff --git a/apps/dashboard/src/lib/features/side-panel/side-panel-rail.svelte b/apps/dashboard/src/lib/features/side-panel/side-panel-rail.svelte index 922cf0d7..889ece02 100644 --- a/apps/dashboard/src/lib/features/side-panel/side-panel-rail.svelte +++ b/apps/dashboard/src/lib/features/side-panel/side-panel-rail.svelte @@ -148,7 +148,7 @@