chore: move orgRole back to session
This commit is contained in:
@@ -3,7 +3,6 @@ import type { TOrganizationApiKeyScope } from '@cio/utils/validation/organizatio
|
||||
|
||||
import { ErrorCodes } from '@api/utils/errors';
|
||||
import { ROLE } from '@cio/utils/constants';
|
||||
import { getOrgRolesForUser } from '@api/utils/redis/org-roles-cache';
|
||||
import { organizationApiKeyHasScopes } from '@api/services/organization/automation-key';
|
||||
|
||||
export const orgAdminOrAutomationKeyMiddleware =
|
||||
@@ -56,7 +55,7 @@ export const orgAdminOrAutomationKeyMiddleware =
|
||||
);
|
||||
}
|
||||
|
||||
const orgRoles = await getOrgRolesForUser(user.id);
|
||||
const orgRoles = (c.get('orgRoles') as Record<string, number> | undefined) ?? {};
|
||||
if (orgRoles[orgId] !== ROLE.ADMIN) {
|
||||
return c.json(
|
||||
{
|
||||
|
||||
@@ -2,11 +2,11 @@ import { Context, Next } from 'hono';
|
||||
|
||||
import { ErrorCodes } from '@api/utils/errors';
|
||||
import { ROLE } from '@cio/utils/constants';
|
||||
import { getOrgRolesForUser } from '@api/utils/redis/org-roles-cache';
|
||||
|
||||
/**
|
||||
* Middleware to check if the authenticated user is an admin of the organization.
|
||||
* Reads `orgRoles` from the Redis-backed cache (DB fallback on miss).
|
||||
* Reads the role from the Better Auth session (populated by the customSession plugin),
|
||||
* so no per-request DB query is performed.
|
||||
*
|
||||
* Requires authMiddleware to be applied first.
|
||||
* Expects orgId in the 'cio-org-id' header.
|
||||
@@ -37,7 +37,7 @@ export const orgAdminMiddleware = async (c: Context, next: Next) => {
|
||||
);
|
||||
}
|
||||
|
||||
const orgRoles = await getOrgRolesForUser(user.id);
|
||||
const orgRoles = (c.get('orgRoles') as Record<string, number> | undefined) ?? {};
|
||||
const roleId = orgRoles[orgId];
|
||||
|
||||
if (roleId !== ROLE.ADMIN) {
|
||||
|
||||
@@ -1,11 +1,9 @@
|
||||
import { Context, Next } from 'hono';
|
||||
import { getOrgRolesForUser } from '@api/utils/redis/org-roles-cache';
|
||||
|
||||
/**
|
||||
* Middleware to check if the authenticated user is a member of the organization.
|
||||
* Loads `orgRoles` from the Redis-backed cache (DB fallback on miss) so the
|
||||
* lookup stays out of the Better Auth session cookie — keeping that cookie
|
||||
* small enough for the oauth-proxy redirect to fit in a Location header.
|
||||
* Reads the role from the Better Auth session (populated by the customSession plugin),
|
||||
* so no per-request DB query is performed.
|
||||
*
|
||||
* Requires authMiddleware to be applied first.
|
||||
* Expects orgId in the 'cio-org-id' header.
|
||||
@@ -37,7 +35,7 @@ export const orgMemberMiddleware = async (c: Context, next: Next) => {
|
||||
);
|
||||
}
|
||||
|
||||
const orgRoles = await getOrgRolesForUser(user.id);
|
||||
const orgRoles = (c.get('orgRoles') as Record<string, number> | undefined) ?? {};
|
||||
const roleId = orgRoles[orgId];
|
||||
|
||||
if (roleId === undefined) {
|
||||
|
||||
Reference in New Issue
Block a user