Isolate npm publish from PR CI, enforce frozen lockfiles and a 24h minimumReleaseAge, and document safe pull_request_target usage so fork PRs cannot reach publish credentials. Co-authored-by: Rotimi Best <rotimi-best@users.noreply.github.com>
48 lines
1.9 KiB
Markdown
48 lines
1.9 KiB
Markdown
## What does this PR do?
|
|
|
|
<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->
|
|
|
|
Fixes # (place issue number here without bracket)
|
|
|
|
<!-- Please provide a screenshots or upload a video for visual changes to speed up reviews -->
|
|
|
|
## Type of change
|
|
|
|
<!-- Please mark the relevant points by using [x] -->
|
|
|
|
- [ ] Bug fix (non-breaking change which fixes an issue)
|
|
- [ ] Chore (refactoring code, technical debt, workflow improvements)
|
|
- [ ] Enhancement (small improvements)
|
|
- [ ] New feature (non-breaking change which adds functionality)
|
|
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
|
- [ ] This change adds a new database migration
|
|
- [ ] This change requires a documentation update
|
|
|
|
## How should this be tested?
|
|
|
|
<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration -->
|
|
|
|
- Test A
|
|
- Test B
|
|
|
|
## Checklist
|
|
|
|
<!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did -->
|
|
|
|
### Required
|
|
|
|
- [ ] Filled out the "How to test" section in this PR
|
|
- [ ] Self-reviewed my own code
|
|
- [ ] Commented on my code in hard-to-understand bits
|
|
- [ ] Ran `pnpm build`
|
|
- [ ] Checked for warnings, there are none
|
|
- [ ] Removed all `console.logs`
|
|
- [ ] Merged the latest changes from main onto my branch with `git pull origin main`
|
|
- [ ] My changes don't cause any responsiveness issues
|
|
- [ ] If this PR changes `pnpm-lock.yaml`, `.github/workflows/**`, or publish config: call that out in the PR description
|
|
|
|
### Appreciated
|
|
|
|
- [ ] If a UI change was made: Added a screen recording or screenshots to this PR
|
|
- [ ] Updated the ClassroomIO Docs if changes were necessary
|